Update GNU IceCat to 91.2.0

* data/files-to-append/browser/locales/en-US/browser/preferences/preferences.ftl
(detect-network-connectivity-option)
(detect-network-connectivity-description): Add label and description
for new IceCat-specific preference for toggling the network
connectivity service.
* data/newtab/directory.png:
* data/newtab/fsf.ico:
* data/newtab/fsf.png:
* data/newtab/gnu.ico:
* data/newtab/gnu.png:
* data/newtab/libreplanet.ico:
* data/newtab/libreplanet.png:
* data/newtab/trisquel.ico:
* data/newtab/trisquel.png:
* data/newtab/wikinews.ico:
* data/newtab/wikinews.png:
* data/newtab/wikipedia-org@2x.png:
* data/newtab/wikipedia.ico:
* data/newtab/wikipedia.png: New files, imported from Trisquel's
Abrowser build helper.  These will be used for the "top sites"
displayed on the newtab page.
* data/patches/default-search-duckduckgo.patch:
* data/patches/duckduckgo-no-params.patch: Remove.  The search engine
machinery has been completely changed upstream, yet again.
* data/patches/disable-settings-services.patch:
* data/patches/hide-protections-dashboard.patch:
* data/patches/icecat-about-dialog.patch:
* data/patches/moz-configure-changes.patch: Adapt to v91.
* data/patches/icecat-preferences.patch: Change the preference key for
the captive portal toggle from 'captivedetect.canonicalURL' to
'network.captive-portal-service.enabled'.  There was at least one
report from several years back that
'network.captive-portal-service.enabled' was not respected:
    https://bugzilla.mozilla.org/show_bug.cgi?id=1481085
But it seems to have been a rare occurrence/bug.  As such, I believe
it's okay to toggle this preference instead of changing the address
'captivedetect.canonicalURL' points to.
* data/settings.js: Set several preferencess to try and disable new
annoying VPN- and mobile-related promos.
* makeicecat: Adapt to v91.  Update FFMAJOR, FFMINOR,
SOURCEBALL_CHECKSUM, and L10N_CMP_REV.  We now require Python 3 and
the jsonschema Python library as build dependencies.  So check for
their existence and error out if they don't.  Given that the search
engine machinery has been completely changed yet again, add a
'configure_search' function to make relevant changes, and ultimately
run the new 'tools/process-json-files.py' Python script.  Also comment
out the 'configure_mobile', to be removed soon, as Mozilla has long
since removed the parts of the firefox code base for mobile builds,
and their mobile browser is now a separate project and code base.
* tools/process-json-files.py: New file, from packagers/maintainers of
Trisquel's Abrowser and Parabola's Iceweasel, for processing and
modifying various JSON files -- such as those relating to search
engines -- in the firefox code base.

1 files changed, 24 insertions, 24 deletions

diff --git a/data/patches/hide-protections-dashboard.patch b/data/patches/hide-protections-dashboard.patch
index 9fd6d4c..d1eb999 100644
--- a/data/patches/hide-protections-dashboard.patch
+++ b/data/patches/hide-protections-dashboard.patch
@@ -1,26 +1,26 @@
---- a/browser/components/customizableui/content/panelUI.inc.xhtml
-+++ b/browser/components/customizableui/content/panelUI.inc.xhtml
-@@ -242,7 +242,7 @@
-                         oncommand="gSync.toggleAccountPanel('PanelUI-fxa', this, event)"/>
-         </toolbaritem>
-         <toolbarseparator class="sync-ui-item"/>
--        <toolbaritem>
-+        <toolbaritem hidden="true">
-           <toolbarbutton id="appMenu-protection-report-button"
-                class="subviewbutton subviewbutton-iconic"
-                oncommand="gProtectionsHandler.openProtections(); gProtectionsHandler.recordClick('open_full_report', null, 'app_menu');">
-@@ -253,7 +253,7 @@
-             </label>
-           </toolbarbutton>
-         </toolbaritem>
--        <toolbarseparator id="appMenu-tp-separator"/>
-+        <toolbarseparator id="appMenu-tp-separator" hidden="true"/>
-         <toolbarbutton id="appMenu-new-window-button"
-                        class="subviewbutton subviewbutton-iconic"
-                        label="&newNavigatorCmd.label;"
---- a/browser/base/content/browser-siteProtections.js
-+++ b/browser/base/content/browser-siteProtections.js
-@@ -1634,7 +1634,7 @@
+--- a/browser/base/content/appmenu-viewcache.inc.xhtml.orig	2021-08-17 16:54:44.323100518 -0400
++++ b/browser/base/content/appmenu-viewcache.inc.xhtml	2021-08-17 16:55:42.131053772 -0400
+@@ -24,7 +24,7 @@
+                       oncommand="gSync.toggleAccountPanel(this, event)"/>
+       </toolbaritem>
+       <toolbarseparator class="sync-ui-item"/>
+-      <toolbaritem>
++      <toolbaritem hidden="true">
+         <toolbarbutton id="appMenu-protection-report-button"
+              class="subviewbutton subviewbutton-iconic"
+              oncommand="gProtectionsHandler.openProtections(); gProtectionsHandler.recordClick('open_full_report', null, 'app_menu');">
+@@ -35,7 +35,7 @@
+           </label>
+         </toolbarbutton>
+       </toolbaritem>
+-      <toolbarseparator id="appMenu-tp-separator"/>
++      <toolbarseparator id="appMenu-tp-separator" hidden="true"/>
+       <toolbarbutton id="appMenu-new-window-button"
+                      class="subviewbutton subviewbutton-iconic"
+                      data-l10n-id="appmenuitem-new-window"
+--- a/browser/base/content/browser-siteProtections.js.orig	2021-08-17 16:52:32.107227395 -0400
++++ b/browser/base/content/browser-siteProtections.js	2021-08-17 16:52:39.303219686 -0400
+@@ -1558,7 +1558,7 @@
        this._trackingProtectionIconContainer.hidden = true;
        return;
      }
@@ -28,4 +28,4 @@
 +    this._trackingProtectionIconContainer.hidden = true;
  
      // Check whether the user has added an exception for this site.
-     let hasException = ContentBlockingAllowList.includes(
+     this.hasException = ContentBlockingAllowList.includes(