commit 0cb9282aeebddeed0b5259f153f98a45311053a5
parent 13a67da614449ec95d1dc1927ed7dca6a1c54fb7
Author: Dimitris Triantafyllidis <dtr@localhost.localdomain>
Date: Sun, 25 Oct 2020 23:20:19 +0200
Smart borders fix: always show borders for floating containers
Currently, in view_autoconfigure, the only condition for show_border
is !view_is_only_visible. view_is_only_visible does not cross the
boundary between the workspace's tiling and floating lists and does not
differentiate between them.
The result is, that in a workspace with zero or more tiling containers
and a single floating container, the floating container will lose its
borders as soon as it is split, provided that a only one view is visible
within the floating container.
Fixed by adjusting the condition for show_borders.
Diffstat:
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sway/tree/view.c b/sway/tree/view.c
@@ -280,7 +280,8 @@ void view_autoconfigure(struct sway_view *view) {
(config->hide_edge_borders_smart == ESMART_NO_GAPS &&
!gaps_to_edge(view));
if (smart) {
- bool show_border = !view_is_only_visible(view);
+ bool show_border = container_is_floating_or_child(con) ||
+ !view_is_only_visible(view);
con->border_left &= show_border;
con->border_right &= show_border;
con->border_top &= show_border;