commit 28b8ea9f1ee57672f39e42521f6ed2aece0d3b2e
parent afca73b6fc799790a1e4c4f103788c357ebecb74
Author: Dominique Martinet <asmadeus@codewreck.org>
Date: Fri, 29 Dec 2017 11:28:10 +0100
cmd_input: cleanup around current_input_config
- Restore old one if we weren't part of a block (should be NULL anyway)
- Check current_input_config got properly allocated
- free temporary current_input_config when done using it
Diffstat:
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/sway/commands/input.c b/sway/commands/input.c
@@ -24,7 +24,11 @@ struct cmd_results *cmd_input(int argc, char **argv) {
char **argv_new = argv+2;
struct cmd_results *res;
+ struct input_config *old_input_config = current_input_config;
current_input_config = new_input_config(argv[0]);
+ if (!current_input_config) {
+ return cmd_results_new(CMD_FAILURE, NULL, "Couldn't allocate config");
+ }
if (strcasecmp("accel_profile", argv[1]) == 0) {
res = input_cmd_accel_profile(argc_new, argv_new);
} else if (strcasecmp("click_method", argv[1]) == 0) {
@@ -60,6 +64,7 @@ struct cmd_results *cmd_input(int argc, char **argv) {
} else {
res = cmd_results_new(CMD_INVALID, "input <device>", "Unknown command %s", argv[1]);
}
- current_input_config = NULL;
+ free_input_config(current_input_config);
+ current_input_config = old_input_config;
return res;
}