commit 4550cb2b3e7e6b4242cf2a3e126b6f47bc8f2182
parent af0f0375ef9aefb1d53e2058ec2f4cf51ee287a5
Author: ael-code <tommy.ael@gmail.com>
Date: Tue, 26 Jun 2018 12:53:47 +0200
fix memleak on background cmd error
- src must be free after join_args()
- wordfree must bee used after wordexp
Diffstat:
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/sway/commands/output/background.c b/sway/commands/output/background.c
@@ -62,8 +62,11 @@ struct cmd_results *output_cmd_background(int argc, char **argv) {
wordexp_t p;
char *src = join_args(argv, j);
if (wordexp(src, &p, 0) != 0 || p.we_wordv[0] == NULL) {
- return cmd_results_new(CMD_INVALID, "output",
- "Invalid syntax (%s).", src);
+ struct cmd_results *cmd_res = cmd_results_new(CMD_INVALID, "output",
+ "Invalid syntax (%s)", src);
+ free(src);
+ wordfree(&p);
+ return cmd_res;
}
free(src);
src = p.we_wordv[0];