sway

commit 842609da6432c054c19c8d10f1660085653daa64
parent 0780d3a465a4aa4157c5c78edf163e104c6d2326
Author: Ronan Pigott <ronan@rjp.ie>
Date:   Wed, 30 Nov 2022 12:02:10 -0700

view: make request_activate take a seat

This way we can move focus on the same seat an activation token
originates from.

Diffstat:
M
include/sway/tree/view.h
 | 
2
+-
M
sway/desktop/xwayland.c
 | 
2
+-
M
sway/tree/view.c
 | 
6
++++--
M
sway/xdg_activation_v1.c
 | 
7
++++++-

4 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/include/sway/tree/view.h b/include/sway/tree/view.h
@@ -271,7 +271,7 @@ void view_set_activated(struct sway_view *view, bool activated);
 /**
  * Called when the view requests to be focused.
  */
-void view_request_activate(struct sway_view *view);
+void view_request_activate(struct sway_view *view, struct sway_seat *seat);
 
 /**
  * If possible, instructs the client to change their decoration mode.
diff --git a/sway/desktop/xwayland.c b/sway/desktop/xwayland.c
@@ -630,7 +630,7 @@ static void handle_request_activate(struct wl_listener *listener, void *data) {
 	if (!xsurface->mapped) {
 		return;
 	}
-	view_request_activate(view);
+	view_request_activate(view, NULL);
 
 	transaction_commit_dirty();
 }
diff --git a/sway/tree/view.c b/sway/tree/view.c
@@ -366,12 +366,14 @@ void view_set_activated(struct sway_view *view, bool activated) {
 	}
 }
 
-void view_request_activate(struct sway_view *view) {
+void view_request_activate(struct sway_view *view, struct sway_seat *seat) {
 	struct sway_workspace *ws = view->container->pending.workspace;
 	if (!ws) { // hidden scratchpad container
 		return;
 	}
-	struct sway_seat *seat = input_manager_current_seat();
+	if (!seat) {
+		seat = input_manager_current_seat();
+	}
 
 	switch (config->focus_on_window_activation) {
 	case FOWA_SMART:
diff --git a/sway/xdg_activation_v1.c b/sway/xdg_activation_v1.c
@@ -31,5 +31,10 @@ void xdg_activation_v1_handle_request_activate(struct wl_listener *listener,
 		return;
 	}
 
-	view_request_activate(view);
+	struct wlr_seat *wlr_seat = event->token->seat;
+	// The requesting seat may have been destroyed.
+	if (wlr_seat) {
+		struct sway_seat *seat = wlr_seat->data;
+		view_request_activate(view, seat);
+	}
 }