sway

commit af45ee2d8be0d36436d3714f8b6e71cbc4115098
parent dc01e884f7d71435015dd3e61f0e269a88975d8a
Author: Brian Ashworth <bosrsf04@gmail.com>
Date:   Sat, 15 Sep 2018 22:21:12 -0400

Handle shell special characters in bg file path

This changes it back so the path given to swaybg is enclosed in quotes.

Additionally, the only character that is escaped in the path stored is
double quotes now. This makes it so we don't need to keep an exhaustive
list of characters that need to be escaped.

The end user will still need to escape these characters in their config
or when passed to swaybg.

Diffstat:
M
sway/commands/output/background.c
 | 
18
++++++------------
M
sway/config/output.c
 | 
4
++--

2 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/sway/commands/output/background.c b/sway/commands/output/background.c
@@ -123,19 +123,13 @@ struct cmd_results *output_cmd_background(int argc, char **argv) {
 			}
 			free(src);
 		} else {
-			// Escape spaces and quotes in the final path for swaybg
+			// Escape double quotes in the final path for swaybg
 			for (size_t i = 0; i < strlen(src); i++) {
-				switch (src[i]) {
-					case ' ':
-					case '\'':
-					case '\"':
-						src = realloc(src, strlen(src) + 2);
-						memmove(src + i + 1, src + i, strlen(src + i) + 1);
-						*(src + i) = '\\';
-						i++;
-						break;
-					default:
-						break;
+				if (src[i] == '"') {
+					src = realloc(src, strlen(src) + 2);
+					memmove(src + i + 1, src + i, strlen(src + i) + 1);
+					*(src + i) = '\\';
+					i++;
 				}
 			}
 
diff --git a/sway/config/output.c b/sway/config/output.c
@@ -237,7 +237,7 @@ void apply_output_config(struct output_config *oc, struct sway_output *output) {
 		wlr_log(WLR_DEBUG, "Setting background for output %d to %s",
 				output_i, oc->background);
 
-		size_t len = snprintf(NULL, 0, "%s %d %s %s %s",
+		size_t len = snprintf(NULL, 0, "%s %d \"%s\" %s %s",
 				config->swaybg_command ? config->swaybg_command : "swaybg",
 				output_i, oc->background, oc->background_option,
 				oc->background_fallback ? oc->background_fallback : "");
@@ -246,7 +246,7 @@ void apply_output_config(struct output_config *oc, struct sway_output *output) {
 			wlr_log(WLR_DEBUG, "Unable to allocate swaybg command");
 			return;
 		}
-		snprintf(command, len + 1, "%s %d %s %s %s",
+		snprintf(command, len + 1, "%s %d \"%s\" %s %s",
 				config->swaybg_command ? config->swaybg_command : "swaybg",
 				output_i, oc->background, oc->background_option,
 				oc->background_fallback ? oc->background_fallback : "");