sway

commit c73c552cae435dd61ebbe0c76aa66570095375a9
parent 6d2b82253a5f2fb0ab8e63ded2b62e5d4088e63b
Author: Dominique Martinet <asmadeus@codewreck.org>
Date:   Sun,  1 Jul 2018 23:12:17 +0900

bar_cmd_modifier: fix use-after-free on error

Found through static analysis.

Diffstat:
M
sway/commands/bar/modifier.c
 | 
5
+++--

1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sway/commands/bar/modifier.c b/sway/commands/bar/modifier.c
@@ -22,9 +22,10 @@ struct cmd_results *bar_cmd_modifier(int argc, char **argv) {
 			mod |= tmp_mod;
 			continue;
 		} else {
+			error = cmd_results_new(CMD_INVALID, "modifier",
+				"Unknown modifier '%s'", split->items[i]);
 			free_flat_list(split);
-			return cmd_results_new(CMD_INVALID, "modifier",
-					"Unknown modifier '%s'", split->items[i]);
+			return error;
 		}
 	}
 	free_flat_list(split);