sway

commit d88460f716939ae3340794a7bf1ba653b51ddb14
parent 83d769805ccb3cef34e0e6167680aeb51ce034e9
Author: Tudor Brindus <me@tbrindus.ca>
Date:   Sun, 19 Apr 2020 19:02:30 -0400

input/cursor: correctly send tablet_v2 up event when over non-v2 surface

If we started holding the tool tip down on a surface that accepts tablet
v2, we should notify that surface if it gets released over a surface
that doesn't support v2.

Since GTK supports tablet v2, this fixes the common case of starting a
drag over a GTK surface (e.g. scrollbar) and releasing it outside (e.g.
over the gaps between sway containers, or in a terminal).

Refs #5230.

Diffstat:
M
sway/input/cursor.c
 | 
7
+++++++

1 file changed, 7 insertions(+), 0 deletions(-)
diff --git a/sway/input/cursor.c b/sway/input/cursor.c
@@ -603,6 +603,13 @@ static void handle_tool_tip(struct wl_listener *listener, void *data) {
 		&surface, &sx, &sy);
 
 	if (!surface || !wlr_surface_accepts_tablet_v2(tablet_v2, surface)) {
+		// If we started holding the tool tip down on a surface that accepts tablet
+		// v2, we should notify that surface if it gets released over a surface that
+		// doesn't support v2.
+		if (event->state == WLR_TABLET_TOOL_TIP_UP) {
+			wlr_tablet_v2_tablet_tool_notify_up(sway_tool->tablet_v2_tool);
+		}
+
 		dispatch_cursor_button(cursor, event->device, event->time_msec,
 				BTN_LEFT, event->state == WLR_TABLET_TOOL_TIP_DOWN ?
 					WLR_BUTTON_PRESSED : WLR_BUTTON_RELEASED);