sway

i3-compatible Wayland compositor
git clone https://git.awy.one/sway
Log | Files | Refs | README | LICENSE

commit f0f20f96aa5cea382ca079b6a88fbcaf5b3782ad
parent 1e1d9e12991e9a9be72da1fe0c887d9087dffe3a
Author: Brian Ashworth <bosrsf04@gmail.com>
Date:   Tue,  2 Apr 2019 13:17:01 -0400

root_scratchpad_hide: fix crash when layer focused

This fixes a crash in `root_scratchpad_hide` when a layer surface is
focused. Since `seat_get_focus` is NULL when a layer surface is
focused, the call to `node_has_ancestor` was causing a SIGSEGV since it
was attempting to access the parent of NULL. This changes the call to
`seat_get_focus_inactive`, which will return a node even when a layer
surface is focused and is also guaranteed to have something in the
focus stack if a scratchpad container is being hidden (otherwise there
would not be any containers yet).

Diffstat:
Msway/tree/root.c | 2+-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sway/tree/root.c b/sway/tree/root.c @@ -135,7 +135,7 @@ void root_scratchpad_show(struct sway_container *con) { void root_scratchpad_hide(struct sway_container *con) { struct sway_seat *seat = input_manager_current_seat(); - struct sway_node *focus = seat_get_focus(seat); + struct sway_node *focus = seat_get_focus_inactive(seat, &root->node); struct sway_workspace *ws = con->workspace; container_detach(con);