sway

commit f2abe0570ff2febe8a25de122c8dc95c49ef8282
parent 478b128c26057dcd7c97aaf5f91aa08dfce7d38f
Author: Brian Ashworth <bosrsf04@gmail.com>
Date:   Tue,  5 Feb 2019 08:35:00 -0500

cmd_workspace_gaps: fix double free on bad amount

This fixes a double free in cmd_workspace_gaps when the amount given is
invalid. The end pointer from strtol is part of the argument and should
not be freed. Freeing the end pointer could result in a double free or
bad free depending on whether or not the end pointer was at the start of
the argument

Diffstat:
M
sway/commands/workspace.c
 | 
1
-

1 file changed, 0 insertions(+), 1 deletion(-)
diff --git a/sway/commands/workspace.c b/sway/commands/workspace.c
@@ -76,7 +76,6 @@ static struct cmd_results *cmd_workspace_gaps(int argc, char **argv,
 	char *end;
 	int amount = strtol(argv[gaps_location + 2], &end, 10);
 	if (strlen(end)) {
-		free(end);
 		return cmd_results_new(CMD_FAILURE, expected);
 	}